-
Notifications
You must be signed in to change notification settings - Fork 3
story/VSPC-189 #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Girik1105
wants to merge
22
commits into
develop
Choose a base branch
from
story/VSPC-189
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
story/VSPC-189 #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… frontend - need to fix api errors
…ix collections and bibliographies
…rt from citesphere working
…- need to remove debug statements, clean code
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]
into[x]
).Please provide a brief description of your ticket
It should be possible to pull in bibliography entries from citesphere
Description
Instead of entering bibliography entries by hand, the user would select entries from Citesphere and those would then be imported. Since Citesphere doesn't have a search endpoint yet, the user would when adding a bibliography block, browse their groups in citesphere and select entries to import. So:
For now, this would be a one time import. We'll worry about updating references from Citesphere later.
The code that pull data from Citesphere should be its own plugin (have Julia create the basic plugin).
VSPC-189
Anything else the reviewer needs to know?
... describe here ...